| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows. |
| Date: | 2009-02-07 15:11:04 |
| Message-ID: | 200902071511.n17FB4t23514@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> mha(at)postgresql(dot)org (Magnus Hagander) writes:
> > Explicitly bind gettext to the correct encoding on Windows.
>
> I have a couple of objections to this patch. First, what happens if
> it fails to find a matching table entry? (The existing answer is
> "nothing", but that doesn't seem right.) Second and more critical,
> it adds still another data structure that has to be maintained when
> the list of encodings changes, and it doesn't even live in the same
> file as any existing encoding-information table.
>
> What makes more sense to me is to add a table to encnames.c that
> provides the gettext name of every encoding that we support.
Would someone please comment on Tom's questions above.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2009-02-07 15:25:51 | pgsql: Properly wrap new pg_dump doc text. |
| Previous Message | Bruce Momjian | 2009-02-07 15:00:27 | pgsql: Update pg_constraint.conkey documentation description. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2009-02-07 15:17:40 | Re: pg_get_viewdef formattiing |
| Previous Message | Greg Stark | 2009-02-07 14:46:27 | Re: [COMMITTERS] pgsql: Implement prefetching via posix_fadvise() for bitmap index scans. |