From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: plpgsql: numeric assignment to an integer variable errors out |
Date: | 2009-01-21 23:59:12 |
Message-ID: | 200901212359.n0LNxC618241@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Nikhil Sontakke wrote:
> > > PFA, patch which uses find_coercion_pathway to find a direct
> > > COERCION_PATH_FUNC function and uses that if it is available. Or is there
> > a
> > > better approach? Seems to handle the above issue with this patch.
> >
> > +1
> >
> > I thing, so some values should by cached, current patch could by slow.
>
>
> Agreed, it can slow things down a bit especially since we are only
> interested in the COERCION_PATH_FUNC case. What we need is a much simpler
> pathway function which searches in the SysCache and returns back with the
> valid/invalid castfunc immediately.
>
> PFA, version 2.0 of this patch with these changes in place. I could have
> added a generic function in parse_coerce.c, but thought the use case was
> restricted to plpgsql and hence I have kept it within pl_exec.c for now.
Where are we on this? 8.5?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2009-01-22 00:00:53 | Re: Pluggable Indexes |
Previous Message | Bruce Momjian | 2009-01-21 23:56:54 | Re: Frames vs partitions: is SQL2008 completely insane? |