Re: solaris libpq threaded build fails

Merlin Moncure wrote:
> On 1/14/09, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > OK, patch attached and applied to CVS HEAD. The nsl (not 'nls') library
> > check was removed in Postgres 8.2 here:
>
> As long as you are looking at this, can you take a peek at this patch?
> http://archives.free.net.ph/message/20081116.053100.15b5801d.fi.html
>
> We had a similar problem on hpux 10.20. This was more invasive change
> though.. At the time, Tom was ambivalent and Dunstan voted that the
> platform was too old, so it never went in.

Thanks, I looked it over. It does have the danger of affecting other
platforms, so there would have to be more checks in there. Also the
calling of the function with all null pointers seems dangerous, though I
am not sure how else we could test this. It might be safer to create a
conflicting function prototype and see if that throws a warning.

I did a Google search and it seems there isn't an easy way to do the
configure check except the approach you have taken. Your changes to
thread.c seem fine.

Comp.programming.threads, has a pretty ugly autoconf example in their
FAQ with the conclusion:

http://www.lambdacs.com/cpt/FAQ.html

> Whom do I shoot?

take your pick :-(

Let me see if I can work up a more minimal patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +