| From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, pgsql-hackers(at)postgresql(dot)org, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, bruce(at)momjian(dot)us, tgl(at)sss(dot)pgh(dot)pa(dot)us, simon(at)2ndQuadrant(dot)com |
| Subject: | Re: Updates of SE-PostgreSQL 8.4devel patches (r1403) |
| Date: | 2009-01-14 07:34:59 |
| Message-ID: | 20090114073459.GB19315@svana.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 13, 2009 at 10:05:45AM -0300, Alvaro Herrera wrote:
> pgace.h: you have a bunch of "static inline" functions in here. As far
> as I know this doesn't work in compilers other than GCC :-( See
> pg_list.h (list_head) for an example. I think we can tolerate this for
> the three functions in pg_list.h because they are so few and so tiny,
> but I'm not sure about PGACE because they are a large lot. On the other
> hand, turning them to real functions would be a performance hit.
Really? C99 requires it and MSVC does support it. At least the other
compilers whose name I remembered (HP, Sun) support it also. I'd be
surprised if a compiler didn't since it's the form of inline that most
matches what people expect to happen.
Do you have an example?
http://www.greenend.org.uk/rjk/2003/03/inline.html
http://hi.baidu.com/junru/blog/item/4d8db11339050c856438db7a.html
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while
> boarding. Thank you for flying nlogn airlines.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | KaiGai Kohei | 2009-01-14 08:04:21 | Re: Updates of SE-PostgreSQL 8.4devel patches (r1403) |
| Previous Message | KaiGai Kohei | 2009-01-14 06:59:50 | Updates of SE-PostgreSQL 8.4devel patches (r1408) |