Re: per-database locale: createdb switches

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: per-database locale: createdb switches
Date: 2009-01-13 16:00:17
Message-ID: 20090113160017.GD4005@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas wrote:
> Peter Eisentraut wrote:

>> I notice in the documentation that the createdb --lc-ctype sets the
>> lc_ctype setting for the database, but the corresponding parameter for
>> CREATE DATABASE is CTYPE, but the global GUC setting is lc_ctype.
>> Should that be more consistent?
>
> Hmm, I remember I pondered for a long time if it should be COLLATE and
> CTYPE or LC_COLLATE and LC_CTYPE. I think the rationale in the end was
> that a) COLLATE/CTYPE looks nicer and b) if we add support for ICU or
> some other collation implementation, the association with LC_*
> environment variables becomes misleading.
>
> Being consistent would be nice, though.

I think consistency could be reached by renaming the GUC setting to
ctype. We could add a "lc_ctype" synonym for backwards compatibility
(like sort_mem) -- or maybe not.

Since the createdb setting is new as of 8.4, we should just rename that
to ctype as well.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2009-01-13 16:18:58 Re: [BUGS] Status of issue 4593
Previous Message Heikki Linnakangas 2009-01-13 15:54:41 Re: per-database locale: createdb switches