From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Sushant Sinha <sushant354(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
Subject: | Re: text search patch status update? |
Date: | 2009-01-08 14:34:42 |
Message-ID: | 200901081434.n08EYgf09060@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
OK, Heikki still believe the behavior below is a bug. Can I get
feedback from anyone else on this? TODO item?
---------------------------------------------------------------------------
> Heikki Linnakangas wrote:
> > Sushant Sinha wrote:
> > > Patch #2. I think this is a straigt forward bug fix.
> >
> > Yes, I think you're right. In hlCover(), *q is 0 when the only match is
> > the first item in the text, and we shouldn't bail out with "return
> > false" in that case.
> >
> > But there seems to be something else going on here as well:
> >
> > postgres=# select ts_headline('1 2 3 4 5', '2'::tsquery, 'MinWords=2,
> > MaxWords=3');
> > ts_headline
> > --------------
> > <b>2</b> 3 4
> > (1 row)
> >
> > postgres=# select ts_headline('aaa1 aaa2 aaa3 aaa4
> > aaa5','aaa2'::tsquery, 'MinWords=2, MaxWords=3');
> > ts_headline
> > ------------------
> > <b>aaa2</b> aaa3
> > (1 row)
> >
> > In the first example, you get three words, and in the 2nd, just two. It
> > must be because of the default ShortWord setting of 3. Also, if only the
> > last word matches, and it's a "short word", you get the whole text:
> >
> > postgres=# select ts_headline('1 2 3 4 5','5'::tsquery, 'MinWords=2,
> > MaxWords=3');
> > ts_headline
> > ------------------
> > 1 2 3 4 <b>5</b>
> > (1 row)
> >
> > --
> > Heikki Linnakangas
> > EnterpriseDB http://www.enterprisedb.com
> >
> > --
> > Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgsql-hackers
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-01-08 14:44:14 | Re: ONLY with parentheses |
Previous Message | Tom Lane | 2009-01-08 14:05:29 | Re: Sample of user-define window function and other things |