Re: pgsql: Declare assorted array functions using anycompatible not anyelem

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Declare assorted array functions using anycompatible not anyelem
Date: 2020-11-09 22:41:34
Message-ID: 2008195.1604961694@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 11/9/20 5:15 PM, Tom Lane wrote:
>> Hm. To fix it this way, we'd have to push the test-script change
>> into the pre-9.5 branches. There's no technical reason we can't do
>> that, I don't think, though it's a bit outside our normal practices.

> I doubt it's necessary. We have provision for adjusting the source
> database before we try to upgrade it. Let me know exactly what you have
> in mind and I'll try to make it work without having to mangle the
> supposedly frozen back branches.

> We don't actually run the regression suite regularly for non-live
> branches, we just try to upgrade a completely static data dir.

What I have in mind to apply to 9.5 through 13 is per attached.
You could either redefine the aggregate similarly in 9.2-9.4,
or just drop it. I doubt the latter leads to any interesting
loss of coverage for xversion upgrade, as there's plenty of other
user-defined aggregates in the regression database.

regards, tom lane

Attachment Content-Type Size
xversion-fix-13.patch text/x-diff 1.9 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2020-11-10 04:02:14 pgsql: jit: Add support for LLVM 12.
Previous Message Andrew Dunstan 2020-11-09 22:35:18 Re: pgsql: Declare assorted array functions using anycompatible not anyelem