Re: ecpg regression test failures caused by window functions patch

[Sorry, have essantially be offline since yesterday. My server didn't ocme up again. Sight. ]

On Sun, Dec 28, 2008 at 03:21:16PM -0500, Tom Lane wrote:
> It hadn't occurred to me to try the ecpg tests before committing the
> window functions patch :-(. It looks like those grammar additions have
> resulted in whitespace changes in a lot of the test outputs. Would you
> confirm that there's nothing seriously wrong and update the output
> files?

Compiler is running atm, will commit changes (if needed) asap.

> It strikes me that it might be a good idea to change cat2_str to not
> insert a space when obviously not necessary, perhaps along the lines
> of
>
> cat2_str(char *str1, char *str2)
> {
> char * res_str = (char *)mm_alloc(strlen(str1) + strlen(str2) + 2);
>
> strcpy(res_str, str1);
> - strcat(res_str, " ");
> + if (strlen(str1) != 0 && strlen(str2) != 0)
> + strcat(res_str, " ");
> strcat(res_str, str2);
> free(str1);
> free(str2);
> return(res_str);
> }

Hey, good idea, will add this too.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!