From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org, "Alex Hunsaker" <badalex(at)gmail(dot)com> |
Subject: | contrib/pg_stat_statements 1226 |
Date: | 2008-12-26 06:04:30 |
Message-ID: | 20081226145707.AF00.52131E4D@oss.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Here is an updated version of contrib/pg_stat_statements patch.
"Alex Hunsaker" <badalex(at)gmail(dot)com> wrote:
> >> I think the explain_analyze_format guc is a clever way of getting
> >> around the explain analyze verbose you proposed earlier. But I dont
> >> see any doc updates for it.
Documentation is added.
> How about just pg_stat_statements.track ?
I renamed the variables to:
- pg_stat_statements.limit
- pg_stat_statements.track
- pg_stat_statements.saved_file
I also modified assign_custom_variable_classes()
to accept '_' as a prefix character, not only 0-9A-Za-z.
> I do like the consistency of having the custom gucs be the same as the
> module name, easy to grep or google for.
Should I also rename variables used in auto_explain module?
It uses 'explain.*' now.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
pg_stat_statements.1226.tar.gz | application/octet-stream | 17.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Koichi Suzuki | 2008-12-26 08:05:31 | Re: V2 of PITR performance improvement for 8.4 |
Previous Message | Andrew Dunstan | 2008-12-26 04:08:56 | Re: NOTIFY extra parameter |