Re: PLUGINS Functionlity in Win32 build scripts

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: MUHAMMAD ASIF <anaeem(dot)it(at)hotmail(dot)com>, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PLUGINS Functionlity in Win32 build scripts
Date: 2008-12-18 20:33:24
Message-ID: 20081218203324.GJ5447@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane escribió:

> AFAICT, the idea of this patch is to make shared libraries that
> automatically install in $libdir/plugins/ rather than $libdir/.
>
> This is actually in direct contradiction to the original intent of the
> plugins/ subdirectory, which was that it only contain libraries that the
> local administrator had decided to consider safe and put there manually.

I think this is fantasy -- the plpgsql debugger already has a makefile
that writes the files directly to the plugins subdir. The admin does
not have to know what's happening, or take any concious decision about
it. He just installs the module (or worse: he just has the module
installed automatically by the "one-click installer").

The only thing this patch does is enable the MSVC build to do it as
easily as the Make-based installation. I don't see the security problem
as this patch's fault.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-12-18 20:43:19 Re: PLUGINS Functionlity in Win32 build scripts
Previous Message Marc Munro 2008-12-18 20:21:40 Re: Patch to eliminate duplicate b64 code from pgcrypto