Re: Patch to eliminate duplicate b64 code from pgcrypto

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Marc Munro <marc(at)bloodnok(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch to eliminate duplicate b64 code from pgcrypto
Date: 2008-12-16 00:10:15
Message-ID: 200812160010.mBG0AFJ08851@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Would someone who understand pgcrypto please review this?

http://archives.postgresql.org/message-id/1216335149.11208.9.camel@bloodnok.com

---------------------------------------------------------------------------

Marc Munro wrote:
-- Start of PGP signed section.
> I am attaching a patch to eliminate duplicate b64_encode and decode
> functions from pgcrypto, and to expose those functions for use by
> add-ins (I want to use them in Veil).
>
> The patch was made against CVS head today. It compiles and tests
> successfully. Though I was unable to run pgrypto regression tests, I
> did give the b64 encoding a sanity check.
>
> I also added a b64_char() function that is now used from pgcrypto. This
> allowed me to remove the duplicate _base64 character array.
>
> I hope this is the correct place to submit the patch. The wiki
> (http://wiki.postgresql.org/wiki/Submitting_a_Patch) refers to
> pgsql-patches but I believe that is now deprecated.
>
>
> __
> Marc

[ Attachment, skipping... ]
-- End of PGP section, PGP failed!

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-12-16 00:18:48 Re: pgsql: Adjust things so that the query_string of a cached plan and the
Previous Message Bruce Momjian 2008-12-16 00:07:48 Re: pgsql: Adjust things so that the query_string of a cached plan and the