| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: snapshot leak and core dump with serializable transactions |
| Date: | 2008-12-03 19:32:18 |
| Message-ID: | 20081203193218.GJ3968@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pavan Deolasee escribió:
> On Wed, Dec 3, 2008 at 7:42 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > That's absolutely wrong. It'll complain about whatever snapshots the
> > owners still hold.
>
> You must be right; I don't understand that code much. But don't we expect
> the snapshots to be cleanly released at that point and if not we flash
> warnings anyways ? AtEOXact_Snapshot only unregisters the serialized
> snapshot which otherwise release resource owner will complain about.
Yeah, we need two "at-commit" routines, one of which needs to be called
early. I'm prepping a patch.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-12-03 19:45:01 | Re: snapshot leak and core dump with serializable transactions |
| Previous Message | Joshua D. Drake | 2008-12-03 19:24:08 | Re: Simple postgresql.conf wizard |