Re: gram.y=>preproc.y

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: gram.y=>preproc.y
Date: 2008-11-11 11:44:31
Message-ID: 20081111114431.GA22087@feivel.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 10, 2008 at 11:03:37AM -0500, Tom Lane wrote:
> * before committing we need to see the proposed diffs to the Makefiles
> and the Windows build scripts.

Sure. I just committed the generated preproc.y file to see how it goes through
the buildfarm. I prefer to see the file is okay everywhere, before automating
things.

> * As-is, the first few lines of parse.pl contain an unportable hardwired
> assumption about where the perl executable is. I'd suggest removing
> ...

Sure, this is just how a2p creates it.

> * Can we get a $PostgreSQL$ version identifier into each file that
> will be added to CVS?

Definitely.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2008-11-11 12:01:57 Re: gram.y=>preproc.y
Previous Message Richard Huxton 2008-11-11 11:03:20 Re: Very slow queries w/ NOT IN preparation (seems like a bug, test case)