| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: auto_explain contrib moudle |
| Date: | 2008-11-10 09:02:41 |
| Message-ID: | 20081110173232.7F2B.52131E4D@oss.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank you for reviewing.
Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> Another question: what is explain.log_analyze supposed to do? Changing
> it doesn't seem to have an effect; it always prints out the actual time.
That's because explain.log_analyze requires executor instruments,
and it's not free. I think we'd better to have an option to avoid
the overheads... Oops, I found my bug when force_instrument is
turned on. It should be enabled only when
(explain_log_min_duration >= 0 && explain_log_analyze).
I send a new patch to fix it. A documentation about
explain.log_nested_statements is also added to the sgml file.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| auto-explain.1110.patch | application/octet-stream | 25.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2008-11-10 09:22:56 | Re: Walsender process patch v1 for Synch Rep |
| Previous Message | Joshua Tolley | 2008-11-10 08:57:57 | Re: Proposed Patch to Improve Performance of Multi-Batch Hash Join for Skewed Data Sets |