From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Russell Smith <mr-russ(at)pws(dot)com(dot)au>, PoolSnoopy <tlatzelsberger(at)gmx(dot)at>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved. |
Date: | 2008-11-07 20:10:29 |
Message-ID: | 20081107201029.GF5507@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Bruce Momjian wrote:
> Thanks for the review, Magnus. I have adjusted the patch to use the
> same mutex every time the counter is accessed, and adjusted the
> pqsecure_destroy() call to properly decrement in the right place.
>
> Also, I renamed the libpq global destroy function to be clearer
> (the function is not exported).
There's a problem in this patch which is that it is inconsistent in its
use of the ENABLE_THREAD_SAFETY symbol. init_ssl_system() is only going
to keep the refcount in the threaded compile; but the safeguards are
needed even when threading is not enabled. Moreover,
destroy_ssl_system() is locking thread mutexes outside
ENABLE_THREAD_SAFETY which is going to cause non-threaded builds to
fail.
As a suggestion, I'd recommend not fooling around with backend files
when you're only modifying libpq. It enlarges the patch without
benefit. I think that patch should be committed separately.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Luiz K. Matsumura | 2008-11-07 22:30:04 | Bug fix request for 08.03.0400 ( was [BUGS] Behavior change of FK info query) |
Previous Message | Tom Lane | 2008-11-07 14:03:12 | Re: Getting "FATAL: unexpected data beyond EOF in block 1 of relation 1663/1/1255/0" on Mac OS during initdb |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2008-11-07 20:12:50 | Re: Updates of SE-PostgreSQL 8.4devel patches (r1197) |
Previous Message | David E. Wheeler | 2008-11-07 19:58:57 | Re: [RRR] Tests citext casts |