| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Annoying error messages in _dosmaperr |
| Date: | 2008-10-15 04:28:27 |
| Message-ID: | 20081015131201.95D3.52131E4D@oss.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
I found that pg_resetxlog always prints the following message on Windows.
mapped win32 error code 2 to 2
Can we supress this annoying message? It seems to come from _dosmaperr,
but the error "postmaster.pid is not found" is a *normal* situation
in pg_resetxlog.
-> open("%s/postmaster.pid", O_RDONLY, 0)
-> pgwin32_open()
-> _dosmaperr()
#ifndef FRONTEND
ereport(DEBUG5, ...);
#else
fprintf(stderr, _("mapped win32 error code %lu to %d"), e, errno);
#endif
DEBUG5 means the messages are completely non-critical. Therefore, client
programs also don't need to report them, no? If possible, I'd like to
remove the #else block (or all of them) from the above routine.
(On the other hand, "unrecognized win32 error code" part should be there.)
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Scott Marlowe | 2008-10-15 05:26:55 | Re: Column level triggers |
| Previous Message | Tom Lane | 2008-10-15 03:21:25 | Re: Bogus attribute-number range checks in spi.c |