From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Add missing header. |
Date: | 2008-10-13 22:07:33 |
Message-ID: | 20081013220733.GD4574@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Tom Lane wrote:
> alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> > Add missing header.
>
> I'm confused. Wouldn't the buildfarm have been complaining if this
> were needed?
It complained that the function was not declared, but it was just a warning.
See for example:
http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=centaur&dt=2008-10-09%20200602&stg=make
ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -g -fpic -I. -I/usr/include/python2.4 -I../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include/et -c -o plpython.o plpython.c
plpython.c: In function '_PG_init':
plpython.c:2752: warning: implicit declaration of function 'set_text_domain'
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-10-14 00:12:44 | pgsql: Eliminate unnecessary array[] decoration in examples of recursive |
Previous Message | Tom Lane | 2008-10-13 16:25:20 | pgsql: Implement comparison of generic records (composite types), and |