From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Jorgen Austvik - Sun Norway <Jorgen(dot)Austvik(at)Sun(dot)COM> |
Cc: | Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_regress inputdir |
Date: | 2008-09-11 15:34:33 |
Message-ID: | 20080911153433.GE9492@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Jorgen Austvik - Sun Norway wrote:
> The attached patch makes pg_regress write converted files to
> <inputdir>/sql and <inputdir>/expected, which is one way to make it read
> and write to the same directory. Tested on Solaris x86 with pgsql "make
> check" and standalone.
Okay, so this patch does change it in a way that it still works, but
what else do you need to be able to run the test from another directory?
I tried to run the test from another directory with this patch
installed, and found that it didn't work because it's replacing
@abs_builddir@ in the input files improperly (to the current path; it
should be using the output dir path, I think)
So maybe this is a step in the right direction, but ISTM you need a
slightly larger patch for it to be actually useful.
If I am not making sense, then maybe I am not understanding what you
mean by running it standalone. In that case, please explain.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-09-11 15:41:05 | Re: Synchronous Log Shipping Replication |
Previous Message | Kenneth Marshall | 2008-09-11 15:24:38 | Re: hash index improving v3 |