| From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | josh(at)agliodbs(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Need more reviewers! |
| Date: | 2008-09-05 20:35:07 |
| Message-ID: | 20080905203507.GC28258@svana.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 04, 2008 at 09:54:02PM +0100, Simon Riggs wrote:
> * coding review - does it follow standard code guidelines? Are there
> portability issues? Will it work on Windows/BSD etc? Are there
> sufficient comments?
>
> * code review - does it do what it says, correctly?
Just one thing though, I picked a random patch and started reading.
However, the commitfest page doesn't link to anywhere that actually
describes *what* the patch is trying to do. Many patches do have the
design and the patch in one page, but some don't.
I suppose what happens is the original patch comes with design and
later a newer version is posted with just changes. The commitfest page
points to the latter, losing former in the archive somewhere.
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while
> boarding. Thank you for flying nlogn airlines.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2008-09-05 20:48:27 | Re: libpq events patch (with sgml docs) |
| Previous Message | Andrew Chernow | 2008-09-05 20:32:25 | Re: [PATCHES] libpq events patch (with sgml docs) |