Re: Uncopied parameters on CREATE TABLE LIKE

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Uncopied parameters on CREATE TABLE LIKE
Date: 2008-08-13 15:03:19
Message-ID: 200808131503.m7DF3J126425@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Added to TODO:

> o Add CREATE TABLE LIKE ... INCLUDING COMMENTS

> * Allow table and index WITH options to be specified via hooks, for use
> with plugins like GiST index methods

---------------------------------------------------------------------------

ITAGAKI Takahiro wrote:
>
> Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>
> > On Tue, 2008-08-12 at 13:34 -0400, Bruce Momjian wrote:
> > > Is there a TODO here?
> >
> > Yes, three:
>
> > * create plugin API to allow extensible reloptions
>
> Yes, and some index access methods (gist and gin) should have
> abilities to handle reloptions in user defined functions, too.
>
> > * allow reloptions to be copied when using INCLUDING DEFAULTS
> > (if I got that right..)
>
> The part "INCLUDING DEFAULTS" is not correct. Reloptions are attribute
> of table, not of columns. So they should not be copied on LIKE and INHERITS.
> Of course, we'd better to have convenient way to copy reltoptions from
> another table, but concrete syntax was not suggested in the discussion.
> (and I don't have.)
>
> > * allow new option to copy comments INCLUDING COMMENTS
>
> Sure.
>
>
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
>

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2008-08-13 15:11:08 Re: Replay attack of query cancel
Previous Message Tim Hawes 2008-08-13 14:39:29 Re: C Extension woes