pgsql: Department of second thoughts: fix newly-added code in planner.c

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Department of second thoughts: fix newly-added code in planner.c
Date: 2008-08-05 16:03:10
Message-ID: 20080805160310.C4C08755315@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Department of second thoughts: fix newly-added code in planner.c to make real
sure that DISTINCT ON does what it's supposed to, ie, sort by the full ORDER
BY list before unique-ifying. The error seems masked in simple cases by the
fact that query_planner won't return query pathkeys that only partially match
the requested sort order, but I wouldn't want to bet that it couldn't be
exposed in some way or other.

Modified Files:
--------------
pgsql/src/backend/optimizer/plan:
planner.c (r1.238 -> r1.239)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/planner.c?r1=1.238&r2=1.239)

Browse pgsql-committers by date

  From Date Subject
Next Message User Andrewd 2008-08-05 18:15:14 pgbuildfarm - client-code: Work around inconsistency in File::Temp's
Previous Message Tom Lane 2008-08-05 15:17:59 pgsql: Add an ORDER BY to one more SELECT DISTINCT test case, per