Re: doc patch - archive/restore_command on windows

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: doc patch - archive/restore_command on windows
Date: 2008-07-18 17:33:17
Message-ID: 200807181733.m6IHXHs26224@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Patch applied to CVS HEAD and 8.3.X. Not sure how this was overlooked
in the past. Thanks.

---------------------------------------------------------------------------

ITAGAKI Takahiro wrote:
> I found the examples of documentation about archive_command and
> restore_command for Windows are incorrect or improper.
>
> - "copy" doesn't accept / (slash) as a path separator.
> We should use \\ (double backslash) for the purpose.
> - Windows path is typically starts with a drive letter (C:\\).
> - We'd better to quote a whole path, not only the last filename
> with double-quotes. It can work, but is not a windows manner.
>
>
> Index: doc/src/sgml/backup.sgml
> ===================================================================
> --- doc/src/sgml/backup.sgml (HEAD)
> +++ doc/src/sgml/backup.sgml (working copy)
> @@ -1122,7 +1122,7 @@
> when so asked. Examples:
> <programlisting>
> restore_command = 'cp /mnt/server/archivedir/%f "%p"'
> -restore_command = 'copy /mnt/server/archivedir/%f "%p"' # Windows
> +restore_command = 'copy "C:\\server\\archivedir/%f" "%p"' # Windows
> </programlisting>
> </para>
> </listitem>
> Index: doc/src/sgml/config.sgml
> ===================================================================
> --- doc/src/sgml/config.sgml (HEAD)
> +++ doc/src/sgml/config.sgml (working copy)
> @@ -1698,7 +1698,7 @@
> and only if it succeeds. Examples:
> <programlisting>
> archive_command = 'cp "%p" /mnt/server/archivedir/"%f"'
> -archive_command = 'copy "%p" /mnt/server/archivedir/"%f"' # Windows
> +archive_command = 'copy "%p" "C:\\server\\archivedir\\%f"' # Windows
> </programlisting>
> </para>
> </listitem>
>
>
>
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
>
>
> --
> Sent via pgsql-patches mailing list (pgsql-patches(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-patches

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2008-07-18 17:33:49 Re: doc patch - archive/restore_command on windows
Previous Message Erik 2008-07-18 17:30:24 Re: [PATCHES] WITH RECUSIVE patches 0717