| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)oryx(dot)com> |
| Cc: | Jaime Casanova <systemguards(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Extending grant insert on tables to sequences |
| Date: | 2008-07-09 19:11:25 |
| Message-ID: | 20080709191125.GK3946@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Abhijit Menon-Sen escribió:
> At 2008-07-08 09:32:44 -0400, alvherre(at)commandprompt(dot)com wrote:
> > Wouldn't it be clearer to build a list with all the sequences owned by
> > the tables in istmt.objects, and then call ExecGrantStmt_oids() a
> > single time with the big list?
>
> i.e., to hoist most of the istmt_seq initialisation out of the loop,
> right? Yes, that makes sense.
No, actually I meant having a lone "list = lappend(list, newseq);" in
the loop, so that ExecGrantStmt_oids is called only once. The
initialization is done only once too, of course.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-07-09 19:14:05 | Re: CommitFest: how does handoff work for non-committer reviewers? |
| Previous Message | Ken Camann | 2008-07-09 19:03:48 | Re: Summary of some postgres portability issues |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aidan Van Dyk | 2008-07-09 20:43:27 | Re: [PATCHES] WITH RECURSIVE updated to CVS TIP |
| Previous Message | Abhijit Menon-Sen | 2008-07-09 18:58:37 | Re: Extending grant insert on tables to sequences |