Re: CommitFest: how does handoff work for non-committer reviewers?

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: CommitFest: how does handoff work for non-committer reviewers?
Date: 2008-07-09 18:50:24
Message-ID: 200807091150.25542.josh@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Neil,

> One approach would be to assign a committer to each patch, in addition
> to a reviewer (the committer and the reviewer might be the same, of
> course). Once the reviewer has signed off on the patch, the committer
> can do the final check over and commit.

Well, one thing I think we want to do by having non-committer reviewers, is
to not involve a committer at all if the patch is going to be sent back.
So one thing I was thinking of is:

1) change status to "ready for committer"
2) post message to -hackers detailing the review and calling for a
committer to check the patch
3) a committer picks it up

--
--Josh

Josh Berkus
PostgreSQL @ Sun
San Francisco

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen R. van den Berg 2008-07-09 18:50:39 Protocol 3, Execute, maxrows to return, impact?
Previous Message Alvaro Herrera 2008-07-09 18:47:09 Re: No answers on CommitFest procedures?