Re: pgsql: Make the pg_stat_activity view call a SRF

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make the pg_stat_activity view call a SRF
Date: 2008-06-27 02:38:45
Message-ID: 200806270238.m5R2cj728701@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Magnus Hagander wrote:
> > Sure, see pg_timezone_abbrevs(), pg_timezone_names().
> >
> > (This only started to work recently, which is why we have so many
> > record-returning functions that don't do it that way. It might be
> > an idea to fix them all sooner or later.)
>
> Wow, that was easy. Not sure where I got the impression it was hard
> from - probably last looked at it before it was made easy, and didn't
> re-check :-)
>
> Updated the pg_stat_get_activity() function to use this.
>
> And yes, I agree that it's probably a very good idea to go over our
> other SRFs and fix them all. I can take a look at that eventually, but
> for now I think we stick it on the TODO?

Added to TODO:

* Fix system views like pg_stat_all_tables to use set-returning
functions, rather than views of per-column functions

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2008-06-27 02:44:32 pgsql: Mention actual function names in documentation of how to pass
Previous Message Bruce Momjian 2008-06-27 02:38:29 pgsql: Add to TODO: > > * Fix system views like pg_stat_all_tables to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hiroshi Saito 2008-06-27 03:28:24 Re: MSVC 2003 compile error with pg8.3.3
Previous Message Andres Freund 2008-06-27 01:21:47 Re: Planner creating ineffective plans on LEFT OUTER joins