From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Patch to change psql default banner v6 |
Date: | 2008-05-14 23:28:01 |
Message-ID: | 200805142328.m4ENS1U23539@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Joshua D. Drake wrote:
> On Wed, 23 Apr 2008 14:41:20 -0700
> "Joshua D. Drake" <jd(at)commandprompt(dot)com> wrote:
>
> Hello,
>
> Per final discussion here:
>
> http://archives.postgresql.org/pgsql-hackers/2008-04/msg01607.php
I have looked over this patch and made a few adjustments.
You used for a help startup banner:
Type: help for help.
I feel this has too much indirection because 'help' then produced:
You are using psql, the command-line interface to PostgreSQL.
\h or \\help for SQL help.
\? for psql help.
\q to quit psql.
\copyright to view the copyright.
Because \? now has \h, \q, and \copyright alone at the top I think we
should just use:
$ psql test
psql (8.4devel) Type \? for help.
test=>
If you type 'help' it just repeats the startup banner suggestion:
test=> help
You are using psql, the command-line interface to PostgreSQL.
Type \? for help.
test=>
I think that consistency will be clearer. In the past we were trying to
avoid \?, but I think now it is clean enough to be used by new people
without confusion.
I also put the version number in parentheses so it wouldn't be as
prominent.
Updated patch attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Attachment | Content-Type | Size |
---|---|---|
/pgpatches/psql_help | text/x-diff | 4.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2008-05-14 23:34:00 | Re: Patch to change psql default banner v6 |
Previous Message | Bruce Momjian | 2008-05-14 20:57:12 | Fix for psql pager computations |