Re: Placement for a /port sort of include file?

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Placement for a /port sort of include file?
Date: 2008-05-14 17:06:37
Message-ID: 20080514170637.GF9838@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Since the function-call-statistics patch is going to need the
> "instr_time" stuff that's currently in src/include/executor/instrument.h,
> I was looking at splitting that out into its own include file. My first
> thought about where to put instr_time.h was under src/include/port/,
> since it's basically a portability abstraction. But all the files that
> are in there right now are platform-specific, so that doesn't seem quite
> right. The precedent of rusagestub.h, getopt_long.h, and a few others
> is to just drop it into src/include/ but that seems a bit ugly too.
> Any thoughts on the matter?

src/include/portable

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2008-05-14 17:06:58 Re: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib
Previous Message Tom Lane 2008-05-14 17:02:06 Placement for a /port sort of include file?