From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum. |
Date: | 2008-05-12 15:10:28 |
Message-ID: | 20080512171028.4573e930@mha-laptop.hagander.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander wrote:
> Tom Lane wrote:
> > mha(at)postgresql(dot)org (Magnus Hagander) writes:
> > > Convert wal_sync_method to guc enum.
> >
> > Buildfarm says you broke things for Windows.
>
> Yeah, working on that with Dave. First part was to unbreak the error
> message so we can actually figure out what's broken :-(
>
I need to leave for a couple of hours, will look again when I get back.
But so far, I'm quite surprised. Here's my reasoning, please poke holes
in it :-)
1) Win32 always defines O_DSYNC (win32.h)
2) That means we should always define OPEN_DATASYNC_FLAG (xlogdefs.h,
line 107)
3) That means that the error should not happen at all, because of
xlog.c line 6358.
Anybody who can kill this argument before I get back ;-) It's obviously
flawed somewhere...
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2008-05-12 16:06:10 | pgsql: Put back bufmgr.h in bufpage.h -- it is needed by some macros. |
Previous Message | Magnus Hagander | 2008-05-12 14:51:35 | Re: pgsql: Convert wal_sync_method to guc enum. |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2008-05-12 16:10:22 | Re: bloated heapam.h |
Previous Message | Tom Lane | 2008-05-12 14:52:37 | Re: [0/4] Proposal of SE-PostgreSQL patches |