| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Bryce Nesbitt <bryce2(at)obviously(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Proposed patch - psql wraps at window width |
| Date: | 2008-05-03 00:32:26 |
| Message-ID: | 200805030032.m430WQq20933@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bryce Nesbitt wrote:
> Tom Lane wrote:
> > Well, personally I haven't read the core code yet, since it's not commit fest yet ;-). I don't know whether there are any issues there, but it wouldn't surprise me given the number of issues in the control code.
> >
> > regards, tom lane
> >
>
> I'm biased because I wrote the patch. However -- I think the core is
> commitable (it won't break anything else, or have complex dependencies
> or bloat).
>
> The issue of $COLUMNS was identified as unresolved at the time the patch
> was submitted, and I think it's the only bit in serious question.
This code is complicated. There is no need to rush and have to revisit
it later.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2008-05-03 00:38:24 | Re: Proposed patch - psql wraps at window width |
| Previous Message | Andrew Dunstan | 2008-05-03 00:26:29 | Re: [COMMITTERS] pgsql: Sigh ... |