| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, Bryce Nesbitt <bryce2(at)obviously(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Brendan Jurd <direvus(at)gmail(dot)com>, heikki(at)enterprisedb(dot)com |
| Subject: | Re: Proposed patch - psql wraps at window width |
| Date: | 2008-04-29 17:11:10 |
| Message-ID: | 200804291911.11917.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Am Dienstag, 29. April 2008 schrieb Bruce Momjian:
> Peter Eisentraut wrote:
> > Am Dienstag, 29. April 2008 schrieb Bruce Momjian:
> > > We do look at COLUMNS if the ioctl() fails, but not for file/pipe
> > > output.
> >
> > This is quite a useless complication. Readline uses exactly the same
> > ioctl() call to determine the columns, so if ioctl() were to fail, then
> > COLUMNS would be unset or wrong as well.
>
> I was thinking about Win32 or binaries that don't have readline.
These rules don't seem very consistent. You are mixing platform dependencies,
build options, theoretical, unproven failures of kernel calls, none of which
have anything to do with each other. For example, if readline weren't
installed, then there would be no one who sets COLUMNS, so why look at it?
If you want to allow users to set COLUMNS manually (possibly useful, see Greg
Stark's arguments), then it should have priority over ioctl(), not the other
way around.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alex Hunsaker | 2008-04-29 17:48:14 | Re: [badalex@gmail.com: Re: [BUGS] Problem identifying constraints which should not be inherited] |
| Previous Message | Zubkovsky, Sergey | 2008-04-29 16:05:01 | Re: [DOCS] pg_total_relation_size() and CHECKPOINT |