| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[]) |
| Date: | 2008-04-28 21:01:25 |
| Message-ID: | 20080428210125.GI5761@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane escribió:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > I came up with the attached patch.
>
> I wasn't envisioning anything anywhere near this invasive. We only
> need locations on constants in a few contexts, I think.
Aha. OK, I'll commit the original patch and let you deal with the rest
of it :-)
> BTW, you broke _equalAConst() ... it was a bad idea anyway to recast
> it on the assumption that there would never again be more than one
> field.
Oops, sorry, I had intended to revert that part and forgot.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-04-28 21:07:28 | Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[]) |
| Previous Message | PFC | 2008-04-28 21:00:18 | Re: Protection from SQL injection |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-04-28 21:07:28 | Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[]) |
| Previous Message | Tom Lane | 2008-04-28 20:57:11 | Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[]) |