Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])
Date: 2008-04-28 20:25:03
Message-ID: 20080428202503.GF5761@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane escribió:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Tom Lane escribió:
> >> They're logically different things, and after I get done putting a parse
> >> location field into A_Const, they'll still be physically different too.
>
> > Aha. Are you working from Brendan's patch? I was going to commit it.
>
> Sure, go ahead. I was going to add the parse location at the same time,
> but it can perfectly well be done as a separate patch.

I came up with the attached patch. I added the location bits (although
I am unsure if I got the locations right in the parser), but they are
unused -- figuring out how to use them would take me longer than I can
to spend on this.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment Content-Type Size
aconst-no-typename-1.patch text/x-diff 41.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2008-04-28 20:47:16 WANTED: VACUUM SUMMARY
Previous Message Stephen Frost 2008-04-28 19:17:35 Re: Protection from SQL injection

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-04-28 20:55:15 Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])
Previous Message Tom Lane 2008-04-28 17:05:38 Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])