Re: Proposed patch - psql wraps at window width

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Gregory Stark <stark(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Brendan Jurd <direvus(at)gmail(dot)com>, Bryce Nesbitt <bryce2(at)obviously(dot)com>, heikki(at)enterprisedb(dot)com
Subject: Re: Proposed patch - psql wraps at window width
Date: 2008-04-25 15:57:04
Message-ID: 200804251557.m3PFv4P08131@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Alvaro Herrera wrote:
> > Bruce Momjian escribi?:
> >
> > > Have a 'format=auto' mode that does aligned/wrapped/expanded, but only
> > > for screen output --- file/pipe would still use aligned. And have
> > > 'format=wrapped' affect file/pipe by requiring the user to specify the
> > > width, or use a default of 72.
> >
> > I have a different question. Why are we mixing file and pipe output? I
> > think the use cases are different and perhaps we should use different
> > defaults.
> >
> > For example, most people I've seen writing shell scripts involving psql
> > output have to pass the -A flag all the time. Perhaps we could change
> > the default output to unaligned for pipes?
>
> Yes, that would make sense to me.
>
> I think the people wanting wrapped to control file/pipe don't want it as
> the default, but want _some_ way of getting wrapped output into a file.

Let me add that the patch as it was posted does not have wrapping
affecting file/pipe output unless you also specify a column width with
\pset. This seemed the most logical and tried to satisfy the most
people. You can see this in the documentation changes of the patch:

ftp://momjian.us/pub/postgresql/mypatches/wrap

I have now clarified the documentation in the patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2008-04-25 16:51:52 Re: MERGE Specification
Previous Message Bruce Momjian 2008-04-25 15:00:36 Re: Proposed patch - psql wraps at window width