Re: WIP: psql default banner patch v3

On Wed, 23 Apr 2008 17:28:04 -0000
"Greg Sabino Mullane" <greg(at)turnstep(dot)com> wrote:

>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: RIPEMD160
>
>
> > WARNING: Server version 8.2, psql version 8.4.
> > psql features may not work.
>
> Can we say "Some psql features..."? the lowercase looks odd.

Yep. I struggled with that through every version of the patch because
the wording is weird as a whole, imo.

Some psql features may not work.
Specialized features may not work?
Version specific features may not work?

etc....

Some is fine. :)

>
> > I left off server version because there doesn't seem to be a
> > reason to have it except if the server doesn't match.
>
> I'd like to have both for consistency's sake. It also helps if you're
> debugging over the phone or looking at a pasted section. It also
> makes the warning message easier, as there is no need to embed
> version numbers inside of it.

O.k. I can buy this argument. I guess if they are running into a bug in
8.1.4 it is an easy way to know.

What are people's thoughts on:

Instead of having all this static info just doing a:

psql <version>
PostgreSQL 8.2.7 on x86_64-pc-linux-gnu,
compiled by GCC cc (GCC) 4.2.3 (Ubuntu 4.2.3-2ubuntu4)

Type: help for help.
postgres=>

>
> If I had enough time, I'd start just making psql backwards-compatible,
> but that's another thread...

oh good lord ... :P

Joshua D. Drake

--
The PostgreSQL Company since 1997: http://www.commandprompt.com/
PostgreSQL Community Conference: http://www.postgresqlconference.org/
United States PostgreSQL Association: http://www.postgresql.us/
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate