Re: WIP: psql default banner patch

On Tue, 22 Apr 2008 17:56:49 -0400
Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:

> > ! puts(_("\tTo view the copyright type
> > \\c . \n"));
>
> The copyright is show with \copyright, not \c.

Doh! I knew that. I will fix after the below discussion :)

>
> I think the warning should be two lines:
>
> WARNING: Server is version %d.%d, %s is version %d.%d.
> Some backslash commands may not work.

I tried that, I thought it looked weird. The single line fits within
the 80 character wrap point. Do we really want to create two lines?

>
>
> > + printf(_("Type: help for help. \n"));
> > +
>
> Here you have a pointless extraneous space.
>

Not that I care but does it matter? I mean it is a space before a
newline.

Sincerely,

Joshua D. Drake

--
The PostgreSQL Company since 1997: http://www.commandprompt.com/
PostgreSQL Community Conference: http://www.postgresqlconference.org/
United States PostgreSQL Association: http://www.postgresql.us/
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate