Re: Lessons from commit fest

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Gregory Stark <stark(at)enterprisedb(dot)com>, Greg Smith <gsmith(at)gregsmith(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Lessons from commit fest
Date: 2008-04-19 03:07:00
Message-ID: 200804190307.m3J370314249@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > It does take a while to run though ... it's not something we'll want to
> > do routinely.
>
> Well, we're not going to want to change the reference typedef list very
> often anyway, because it'd just result in whitespace-thrashing in the
> repository. I'm thinking an update once or twice per major release
> cycle would be enough. So a basically manual process that combines the
> results from various buildfarm members, and then filters them like this,
> should be workable.

OK, fine, but when I do the full source tree pgindent, I will need a URL
to get the list, so let's document its location in the README.

Also, this improved typedef list is only making pgindent 0.2% better.
Does someone want to look at improving the pgindent script itself? Might
be a good time now that we have an updated typedef list for 8.4.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-04-19 03:07:17 Re: Lessons from commit fest
Previous Message Tom Lane 2008-04-19 03:01:09 Re: Lessons from commit fest