| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Zoltan Boszormenyi <zb(at)cybertec(dot)at>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: float4/float8/int64 passed by value with tsearch fixup |
| Date: | 2008-04-18 20:19:24 |
| Message-ID: | 20080418201924.GH572@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
> Specifically, I think what you missed is that on some platforms C
> functions pass or return float values differently from similar-sized
> integer or pointer values (typically, the float values get passed in
> floating-point registers).
Argh ... I would have certainly missed that.
> It'd be less ugly to convert to v1 calling convention.
Okay -- I'll change contrib/seg to v1 to greenify back the buildfarm.
> So I think we really do need to offer that compile-time option.
> Failing to do so will be tantamount to desupporting v0 functions
> altogether, which I don't think we're prepared to do.
I have asked the Cybertec guys for a patch. Since it's basically a copy
of the float8 change, it should be easy to do.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-04-18 21:22:52 | Re: Testing pg_terminate_backend() |
| Previous Message | Tom Lane | 2008-04-18 20:09:26 | Re: float4/float8/int64 passed by value with tsearch fixup |