Re: Lessons from commit fest

Chris Browne wrote:
> bruce(at)momjian(dot)us (Bruce Momjian) writes:
> > Magnus Hagander wrote:
> >> > And I think adopting surrounding naming, commeting, coding conventions
> >> > should come naturally as it can aide in copy-pasting too :)
> >>
> >> I think pg_indent has to be made a lot more portable and easy to use
> >> before that can happen :-) I've run it once or twice on linux machines,
> >> and it comes out with huge changes compared to what Bruce gets on his
> >> machine. Other times, it doesn't :-) So yeah, it could be that it just
> >> needs to be made easier to use, because I may certainly have done
> >> something wrong.
> >
> > Agreed, pgindent is too cumbersome to require patch submitters to use.
> > One idea would be to allow C files to be emailed and the indented
> > version automatically returned via email.
>
> Would it be a terrible idea to...
>
> - Draw the indent code from NetBSD into src/tools/pgindent
> - Build it _in place_ inside the code tree (e.g. - don't assume
> it will get installed in /usr/local/bin)
> - Thus have the ability to run it in place?

Yes, but it bloats our code and people still need to generate the
typedefs and follow the instructions. The other problem is if they run
it on a file they have modified, it is going to adjust places they
didn't touch, thereby making the patch harder to review.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +