From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Brendan Jurd <direvus(at)gmail(dot)com> |
Cc: | "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Lessons from commit fest |
Date: | 2008-04-16 16:36:50 |
Message-ID: | 200804161636.m3GGaoH05939@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Brendan Jurd wrote:
> > The idea that we "fix" stylistic issues on the fly is not sustainable.
> > We should offer help and mentorship to new patch submitters in all
> > areas (including stylistic) but they should do the work. It is the only
> > way we will mold them to submit patches in the proper way.
> >
>
> I agree. As a submitter I would much rather get an email saying e.g.
> "Hey, your patch is nice but the code style sticks out like a sore
> thumb. Please adopt surrounding naming convention and fix your
> indentation per the rules at [link]." than have it fixed silently on
> its way to being committed.
>
> With the former I learn something and get to improve my own work.
> With the latter, my next patch is probably going to have the exact
> same problem, which is in the long term just making extra work for the
> reviewers.
If the patch submitters hasn't read the developers' FAQ, we assume they
are not interested in improving the style of their patch.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2008-04-16 16:39:42 | Re: Lessons from commit fest |
Previous Message | Bruce Momjian | 2008-04-16 16:32:58 | Re: pg_terminate_backend() issues |