| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single |
| Date: | 2008-04-15 17:38:41 |
| Message-ID: | 200804151738.m3FHcfx25866@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Alvaro Herrera wrote:
> >> I wonder if it's OK to grab an LWLock in a signal handler.
>
> > I am not in a signal handler there --- pg_terminate_backend() happens
> > for the person requesting the termination, not the terminated backend
> > that gets the signal.
>
> A more interesting question is what makes you think that taking
> ProcArrayLock here has any value whatsoever.
I took the lock so I would be sure the PGPROC array was the matching pid
and not some other pid that was created between my check and the setting
of the variable.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-04-15 18:22:31 | Re: Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single |
| Previous Message | Tom Lane | 2008-04-15 17:32:09 | Re: Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2008-04-15 17:42:59 | Re: pulling libpqtypes from queue |
| Previous Message | Tom Lane | 2008-04-15 17:32:09 | Re: Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single |