| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Gregory Stark <stark(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Lessons from commit fest |
| Date: | 2008-04-15 16:12:24 |
| Message-ID: | 20080415161224.GG4429@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> I tend to just fix this stuff while committing, rather than lecture the
> submitters about it, but it undoubtedly is a time sink.
Lesson learned: a useful task for another reviewer to do is to grab the
patch, fix the style issues, and post the fixed version. That way, the
"higher level reviewer" does not have to waste time on a task that,
really, anybody can do.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gregory Stark | 2008-04-15 16:13:53 | Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single |
| Previous Message | Oleg Bartunov | 2008-04-15 16:08:25 | Re: Problem with site doc search |