From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Terminating a backend |
Date: | 2008-04-14 17:52:38 |
Message-ID: | 200804141752.m3EHqcI13649@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
oikBruce Momjian wrote:
> Bruce Momjian wrote:
> > > > When we get the termination signal, why can't we just set a global
> > > > boolean, do a query cancel, and in the setjmp() code block check the
> > > > global and exit --- at that stage we know we have released all locks and
> > > > can exit cleanly.
> > >
> > > I have implemented this idea with the attached patch.
> >
> > One problem I have with my patch is that SIGTERM is currently used by
> > the postmaster to shut down backends. Now because the postmaster knows
> > that all backend are terminating, it can accept a dirtier shutdown than
> > one where we are terminating just one backend and the rest are going to
> > keep running. The new SIGTERM coding is going to exit a backend only in
> > a place where cancel is checked.
>
> I have a idea --- to have pg_terminate_backend() set a PGPROC boolean
> and then send a query cancel signal to the backend --- the backend can
> then check the boolean and exit if required. I will work on a new
> version of this patch tomorrow/Monday.
Updated patch attached. I didn't modify SIGTERM at all but set a PRPROC
boolean and piggybacked on SIGINT. I think I got the PGPROC locking
right. I had to split apart pg_signal_backend() so I could do the
permission and pid checks independent of the signalling, because I
pg_terminate_backend() needs to check, then set the PGPROC variable,
then send the signal.
I also added an administration doc mention about when to use
pg_terminate_backend().
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Attachment | Content-Type | Size |
---|---|---|
/pgpatches/terminate | text/x-diff | 9.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-04-14 18:12:08 | Re: Lessons from commit fest |
Previous Message | Tom Lane | 2008-04-14 17:41:34 | Re: pg_dump object sorting |
From | Date | Subject | |
---|---|---|---|
Next Message | Brendan Jurd | 2008-04-14 21:23:13 | Removing typename from A_Const (was: Empty arrays with ARRAY[]) |
Previous Message | Tom Lane | 2008-04-14 16:48:19 | Re: [HACKERS] Remove lossy-operator RECHECK flag? |