Re: printTable API (was: Show INHERIT in \du)

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: printTable API (was: Show INHERIT in \du)
Date: 2008-04-13 20:03:20
Message-ID: 20080413200320.GB21979@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Brendan Jurd escribió:

> I'd like to submit my first version of this patch for review. I have
> introduced a new struct in print.h called printTableContent, which is
> used to compose the contents of a psql table. The methods exposed for
> this struct are as follows:

Looks cool -- on a first read, I think you should add some more code
comments at the top of each function specifying whether the texts need
to be translated by the caller or done by the function itself. Also it
would be good if it is consistent, too :-)

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-04-13 20:04:51 Re: [HACKERS] Terminating a backend
Previous Message Tom Lane 2008-04-13 19:21:06 Re: Remove lossy-operator RECHECK flag?

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-04-13 20:04:51 Re: [HACKERS] Terminating a backend
Previous Message Tom Lane 2008-04-13 19:21:06 Re: Remove lossy-operator RECHECK flag?