pgsql: Replace "amgetmulti" AM functions with "amgetbitmap", in which

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Replace "amgetmulti" AM functions with "amgetbitmap", in which
Date: 2008-04-10 22:25:26
Message-ID: 20080410222526.878DF7559CC@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Replace "amgetmulti" AM functions with "amgetbitmap", in which the whole
indexscan always occurs in one call, and the results are returned in a
TIDBitmap instead of a limited-size array of TIDs. This should improve
speed a little by reducing AM entry/exit overhead, and it is necessary
infrastructure if we are ever to support bitmap indexes.

In an only slightly related change, add support for TIDBitmaps to preserve
(somewhat lossily) the knowledge that particular TIDs reported by an index
need to have their quals rechecked when the heap is visited. This facility
is not really used yet; we'll need to extend the forced-recheck feature to
plain indexscans before it's useful, and that hasn't been coded yet.
The intent is to use it to clean up 8.3's horrid @@@ kluge for text search
with weighted queries. There might be other uses in future, but that one
alone is sufficient reason.

Heikki Linnakangas, with some adjustments by me.

Modified Files:
--------------
pgsql/doc/src/sgml:
catalogs.sgml (r2.163 -> r2.164)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/catalogs.sgml?r1=2.163&r2=2.164)
indexam.sgml (r2.23 -> r2.24)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/indexam.sgml?r1=2.23&r2=2.24)
pgsql/src/backend/access/gin:
ginget.c (r1.10 -> r1.11)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/ginget.c?r1=1.10&r2=1.11)
pgsql/src/backend/access/gist:
gistget.c (r1.69 -> r1.70)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gist/gistget.c?r1=1.69&r2=1.70)
pgsql/src/backend/access/hash:
hash.c (r1.100 -> r1.101)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/hash/hash.c?r1=1.100&r2=1.101)
pgsql/src/backend/access/index:
genam.c (r1.65 -> r1.66)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/index/genam.c?r1=1.65&r2=1.66)
indexam.c (r1.104 -> r1.105)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/index/indexam.c?r1=1.104&r2=1.105)
pgsql/src/backend/access/nbtree:
nbtree.c (r1.156 -> r1.157)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/nbtree/nbtree.c?r1=1.156&r2=1.157)
pgsql/src/backend/executor:
nodeBitmapHeapscan.c (r1.25 -> r1.26)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeBitmapHeapscan.c?r1=1.25&r2=1.26)
nodeBitmapIndexscan.c (r1.25 -> r1.26)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeBitmapIndexscan.c?r1=1.25&r2=1.26)
pgsql/src/backend/nodes:
tidbitmap.c (r1.14 -> r1.15)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/tidbitmap.c?r1=1.14&r2=1.15)
pgsql/src/include/access:
genam.h (r1.69 -> r1.70)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/genam.h?r1=1.69&r2=1.70)
gin.h (r1.16 -> r1.17)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/gin.h?r1=1.16&r2=1.17)
gist_private.h (r1.28 -> r1.29)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/gist_private.h?r1=1.28&r2=1.29)
hash.h (r1.86 -> r1.87)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/hash.h?r1=1.86&r2=1.87)
nbtree.h (r1.116 -> r1.117)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/nbtree.h?r1=1.116&r2=1.117)
relscan.h (r1.61 -> r1.62)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/relscan.h?r1=1.61&r2=1.62)
pgsql/src/include/catalog:
catversion.h (r1.446 -> r1.447)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h?r1=1.446&r2=1.447)
pg_am.h (r1.54 -> r1.55)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_am.h?r1=1.54&r2=1.55)
pg_proc.h (r1.487 -> r1.488)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h?r1=1.487&r2=1.488)
pgsql/src/include/nodes:
tidbitmap.h (r1.6 -> r1.7)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/tidbitmap.h?r1=1.6&r2=1.7)
pgsql/src/include/utils:
rel.h (r1.105 -> r1.106)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/rel.h?r1=1.105&r2=1.106)
pgsql/src/test/regress/expected:
create_index.out (r1.27 -> r1.28)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/create_index.out?r1=1.27&r2=1.28)
oidjoins.out (r1.21 -> r1.22)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/oidjoins.out?r1=1.21&r2=1.22)
pgsql/src/test/regress:
parallel_schedule (r1.46 -> r1.47)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/parallel_schedule?r1=1.46&r2=1.47)
serial_schedule (r1.43 -> r1.44)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/serial_schedule?r1=1.43&r2=1.44)
pgsql/src/test/regress/sql:
create_index.sql (r1.23 -> r1.24)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/create_index.sql?r1=1.23&r2=1.24)
oidjoins.sql (r1.21 -> r1.22)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/oidjoins.sql?r1=1.21&r2=1.22)

Added Files:
-----------
pgsql/src/test/regress/expected:
bitmapops.out (r1.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/bitmapops.out?rev=1.1&content-type=text/x-cvsweb-markup)
pgsql/src/test/regress/sql:
bitmapops.sql (r1.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/bitmapops.sql?rev=1.1&content-type=text/x-cvsweb-markup)

Browse pgsql-committers by date

  From Date Subject
Next Message User Jbcooley 2008-04-10 23:29:50 npgsql - Npgsql2: Sspi patch from Brar Piening
Previous Message Bruce Momjian 2008-04-10 18:58:15 pgsql: Add TODO URLs moved from open items queue: >