Re: Headers dependencies cleanup

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Headers dependencies cleanup
Date: 2008-04-05 14:33:29
Message-ID: 200804051433.m35EXTd18952@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Zdenek Kotala wrote:
> Tom Lane napsal(a):
> > Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> >>>> During my work I found some header files, which include useless headers
> >>>> and on other way there are some headers which silently assume that
> >>>> requested header will be included by some other headers file.
> >>> Bruce periodically runs a script that's supposed to catch this type
> >>> of problem. Maybe we are overdue for another run?
> >
> >> Yes, but This problem is there for long time and I think Bruce's script does not
> >> catch it.
> >
> > Exactly what problem do you see that he didn't catch?
>
> bufpage.h includes bufmgr.h, but bufpage.h does not require any definition from
> bufmgr.h. I think this dependency is there for long time.

My scripts should have found this issue, see
src/tools/pginclude/pgrminclude.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-04-05 15:05:21 Re: Headers dependencies cleanup
Previous Message Bruce Momjian 2008-04-05 14:31:59 Re: Headers dependencies cleanup