From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, bobtfish(at)bobtfish(dot)net |
Subject: | Re: Re: [COMMITTERS] pgsql: Implement current_query(), that shows the currently executing |
Date: | 2008-04-05 01:46:05 |
Message-ID: | 200804050146.m351k5V18056@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera wrote:
> Bruce Momjian wrote:
>
> > > >> Alvaro Herrera wrote:
> > > >>> I think the agreement was that dblink_current_query was to be
> > > >>> implemented on top of this. In fact I don't see any reason not to.
>
> > OK. Did someone mention this before because I don't remember it and the
> > patch removed the dblink usage. Do we continue to document the
> > function?
>
> Yes, I did:
>
> http://archives.postgresql.org/pgsql-patches/2007-05/msg00098.php
I see what happened. The author said he had made the change, but the
patch didn't contain it:
http://archives.postgresql.org/pgsql-patches/2007-05/msg00132.php
> > FWIW I think you should still provide dblink_current_query, even if it's
> >
> > only a wrapper over current_query(), for backwards compatibility.
>
> Good point. Done as suggested (I think, or did you mean also the change
> of instances to use current_query()?). Replaced dblink_current_query
> with an SQL procedure wrapper, I assume that's the most efficient way of
> doing it?
So do we document it or just add a function entry point?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-04-05 01:58:21 | pgsql: Defend against JOINs having more than 32K columns altogether. |
Previous Message | Alvaro Herrera | 2008-04-05 01:39:15 | Re: Re: [COMMITTERS] pgsql: Implement current_query(), that shows the currently executing |
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2008-04-05 01:49:26 | Re: Patch queue -> wiki |
Previous Message | Alvaro Herrera | 2008-04-05 01:39:15 | Re: Re: [COMMITTERS] pgsql: Implement current_query(), that shows the currently executing |