Re: Moving snapshot code around

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, Pg Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Moving snapshot code around
Date: 2008-03-26 21:14:12
Message-ID: 20080326211412.GQ29730@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Tom Lane wrote:

> >> I don't like that very much. What about just moving the HTSU_Result
> >> enum's declaration somewhere else? Two possibilities are heapam.h
> >> itself, or the new snapshot.h file (which'd then have to be included
> >> by heapam.h, but it seems lightweight enough that that's not too
> >> terrible).
>
> > Well, heapam.h includes a lot of other headers, so it doesn't look a
> > good candidate to me. I think snapshot.h is a reasonably good
> > candidate.
>
> Works for me.

This part done too.

Thanks for the input.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Marc G. Fournier 2008-03-26 22:28:49 Re: Script binaries renaming
Previous Message Tom Lane 2008-03-26 20:49:20 Re: V1.1 patch for TODO Item: SQL-language reference parameters by name.