Re: Idea for minor tstore optimization

Added to TODO:

* Avoid tuple some tuple copying in sort routines

http://archives.postgresql.org/pgsql-hackers/2008-02/msg01206.php

---------------------------------------------------------------------------

Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > I notice that several of the call sites of tuplestore_puttuple() start
> > with arrays of datums and nulls, call heap_form_tuple(), and then switch
> > into the tstore's context and call tuplestore_puttuple(), which
> > deep-copies the HeapTuple into the tstore. ISTM it would be faster and
> > simpler to provide a tuplestore_putvalues(), which just takes the datum
> > + nulls arrays and avoids the additional copy.
>
> Seems reasonable. Check whether tuplesort should offer the same, while
> you are at it.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +