From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Use -fwrapv in CFLAGS if we are using a version of gcc that |
Date: | 2008-03-10 21:50:42 |
Message-ID: | 20080310215042.EBCBE753F33@cvs.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Use -fwrapv in CFLAGS if we are using a version of gcc that accepts this flag.
This prevents compiler optimizations that assume overflow won't occur, which
breaks numerous overflow tests that we need to have working. It is known
that gcc 4.3 causes problems and possible that 4.1 does. Per my proposal
of some time ago and a recent report from Kris Jurka.
Backpatch as far as 8.0, which is as far as the patch conveniently goes.
7.x was pretty short of overflow tests anyway, so it may not matter there,
even assuming that anyone cares whether 7.x builds on recent gcc.
Tags:
----
REL8_1_STABLE
Modified Files:
--------------
pgsql:
configure.in (r1.431.2.23 -> r1.431.2.24)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/configure.in?r1=1.431.2.23&r2=1.431.2.24)
configure (r1.461.2.22 -> r1.461.2.23)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/configure?r1=1.461.2.22&r2=1.461.2.23)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-03-10 21:50:53 | pgsql: Use -fwrapv in CFLAGS if we are using a version of gcc that |
Previous Message | Tom Lane | 2008-03-10 21:50:33 | pgsql: Use -fwrapv in CFLAGS if we are using a version of gcc that |