remove TCL_ARRAYS

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Pg Patches <pgsql-patches(at)postgresql(dot)org>
Subject: remove TCL_ARRAYS
Date: 2008-02-29 14:34:14
Message-ID: 20080229143414.GE4673@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

This patch removes the TCL_ARRAY symbol. This seems to be a leftover
from when pgtcl was around in the backend; if enabled, it causes
array_out to emit bogus array values:

alvherre=# create table bar ( a text);
CREATE TABLE
alvherre=# insert into bar values ('foo"');
INSERT 0 1
alvherre=# select array_append('{}', a) from bar;
array_append
--------------
{"foo""}
(1 ligne)

The correct value is

alvherre=# select array_append('{}', a) from bar;
array_append
--------------
{"foo\""}
(1 ligne)

Of course, the system does not accept the TCL_ARRAY value back.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment Content-Type Size
remove-tcl-arrays.patch text/x-diff 1.1 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Robert Lor 2008-02-29 14:39:23 Re: DTrace probe patch for OS X Leopard
Previous Message Robert Lor 2008-02-29 14:17:00 Re: DTrace probe patch for OS X Leopard